-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to send attachments in an interaction initial response #971
Add ability to send attachments in an interaction initial response #971
Conversation
I'ma see if i can work on the rest server equivalent logic for this today |
Btw I do have a prototype impl of sending attachments on rest but i'm going to be waiting for discord to push a change they said they'd be pushing soon:tm: so if you remove the interaction server from this pr and switch out to handling de-duplicating the logic by moving out the payload building logic to a separate function instead of making the create_message logic work for create initial response this can be merged without the server logic (and i'll do the server logic in another pr) |
Sry for the delay |
For a bit more specific detail on how I think this should be handled: instead of modifying def _build_message(self, message_body: JSONObjectBuilder, ...) -> Optional[URLEncodedFormBuilder]: where _build_message should cover both edit and create semantics, and if it returns a |
f0c8167
to
aa9bcdd
Compare
Tests are still a TODO but a pre-emptive review would be welcomed @FasterSpeeding 😉 |
Meow |
Woof |
b505045
to
5eec844
Compare
Summary
Adds the ability to pass attachments with
create_initial_response
Checklist
nox
and all the pipelines have passed.Related issues