Merge ed25519 dependencies to an optional server feature flag #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FasterSpeeding
force-pushed
the
task/pynacl
branch
from
4b9e4b6 to
58e268a
Compare
davfsa
reviewed
Jan 29, 2022
FasterSpeeding
commented
Jan 31, 2022
davfsa
reviewed
Feb 2, 2022
davfsa
reviewed
Feb 2, 2022
Rename pytest-speedups to pytest-all-features
FasterSpeeding
force-pushed
the
task/pynacl
branch
from
cbaf783 to
d8d1bdc
Compare
davfsa
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the old pure ed25519 and ed25519 dependencies and replaces them with one optional pynacl dependency which is installed with the "server" feature flag.
The goal being to stream-line ed25519 handling, remove dependency on less-well maintained projects (as ed25519 is currently blocking py 3.11 support) and remove dependency on pure ed25519 which from a technical cryptographic perspective hasn't been "validated" like libsodium
Checklist
noxand all the pipelines have passed.Related issues