Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS web scraping problem #161

Closed
hildogjr opened this issue Jan 20, 2018 · 1 comment
Closed

RS web scraping problem #161

hildogjr opened this issue Jan 20, 2018 · 1 comment
Assignees
@hildogjr
Labels
bug Bugs that impacts on main KiCost functionality.

Comments

@hildogjr
Copy link
Owner

hildogjr commented Jan 20, 2018 •
edited
Loading

The RS submodule also have present some issue (related with #146).
Creating a CSV with just CRCW120610K0FKEA part, RS web scrape module return nothing. All the others modules respond correctly.
In first analyses, is relative to the commented code in the file rs.py.
@hildogjr hildogjr added the bug Bugs that impacts on main KiCost functionality. label Jan 20, 2018
@hildogjr hildogjr mentioned this issue Jan 22, 2018
Open
@hildogjr hildogjr mentioned this issue Feb 10, 2018
Closed
@hildogjr
Copy link
Owner Author

hildogjr commented Feb 10, 2018 •
edited
Loading

Founded some issues in this code:

  1. 'primarySearchLink' (line 158) web class dosn't exist on RS web page, may be the main cause here (the page style changed);
  2. Is not making use of get_close_matches() like the other distributors modules, this may change the comparative behavior.

@hildogjr hildogjr mentioned this issue Feb 24, 2018
Closed
@hildogjr hildogjr self-assigned this Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildogjr hildogjr

Labels
bug Bugs that impacts on main KiCost functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hildogjr