Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octopart (and EDAs) class format #320

Closed
hildogjr opened this issue Sep 28, 2018 · 3 comments
Closed

Octopart (and EDAs) class format #320

hildogjr opened this issue Sep 28, 2018 · 3 comments
Assignees
Labels
enhancement Improvements on features already existent.

Comments

@hildogjr
Copy link
Owner

hildogjr commented Sep 28, 2018

Since #314 is almost finished (missing fix new bug that will raise), @mmmaisel, could you give a lock (some help to me) in the branch
https://github.com/xesscorp/KiCost/tree/octopart_class
?

I:

  1. Changing the folder structs of KiCost and trying to eliminate the submodule concept (it never help me to debug or leave me import separately);
  2. Change the distributors class and it __init__.py (where I need your tip) to import the files with class and not packages/folder anymore;
  3. Trying to do the same to the EDAs.

Are this concept pythonize?

@hildogjr hildogjr added the enhancement Improvements on features already existent. label Sep 28, 2018
@hildogjr hildogjr changed the title Octopart (an EDAs) class format Octopart (and EDAs) class format Sep 28, 2018
@hildogjr
Copy link
Owner Author

hildogjr commented Sep 29, 2018

@xesscorp, please check the octopart_class branch. After we follow the work flow,I think I haven't this level of access to your GitHub KiCost project (change the names and set the master):

  1. master became scrape
  2. octopart (documentation already updated) became master
  3. Release KiCost
  4. octopart_class merge into master (old octopart)

@hildogjr
Copy link
Owner Author

hildogjr commented Oct 3, 2018

Release and merges did. Please, @mmmaisel & @xesscorp, check main branch for future codes.

@hildogjr hildogjr self-assigned this Oct 6, 2018
@mmmaisel
Copy link
Contributor

mmmaisel commented Oct 6, 2018

  • Change the distributors class and it __init__.py (where I need your tip) to import the files with class and not packages/folder anymore;

I can't recommend doing this. The correct code works perfectly and consists of only two lines while the auto-import thing is much longer than 20 lines, buggy and probably dangerous (imaging some bad guy places some files within that directory that gets silently executed during the next run of KiCost).

The new master code looks good now and works well. I'll create a pull request with some more code cleanups soon.

@mmmaisel mmmaisel mentioned this issue Oct 6, 2018
@hildogjr hildogjr closed this as completed Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements on features already existent.
Projects
None yet
Development

No branches or pull requests

2 participants