Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TME #76

Closed
maciekKuba opened this issue Aug 27, 2017 · 8 comments
Closed

Support for TME #76

maciekKuba opened this issue Aug 27, 2017 · 8 comments
Labels
feature-request New features resquested.

Comments

@maciekKuba
Copy link

maciekKuba commented Aug 27, 2017

I would like to add support for tme.eu distributor. I don't have much experience with python but I'm ready to learn. With some tips I hope I will manage developing it.

@hildogjr
Copy link
Owner

This site understand the manufacture part number? (that identify a IC model + packge + work temperature ..., for example)

I did not know this distributor.

@maciekKuba
Copy link
Author

@adamheinrich
Copy link
Contributor

Hi, I've recently started working on this feature, because I need TME as well:) It seems to be quite straightforward (copy existing distributor implementation and go through TME's HTML structure).

Have you already started? It would be a pity to duplicate the effort.

@maciekKuba
Copy link
Author

No, I didn't started. Ok, so how do you suggest to collaborate? I also noticed that TME delivers API. I looked on it and it seems to be an access to their database. Please look at this https://developers.tme.eu . Maybe it would be simpler to use it.

@hildogjr
Copy link
Owner

Dear @adamheinrich,
What about merge this effort with the issue #77?

@adamheinrich
Copy link
Contributor

adamheinrich commented Aug 29, 2017

@maciekKuba I've just pushed my code from last week to https://github.com/adamheinrich/KiCost/tree/distributor-tme-dev. It seems to work, but it needs to be properly tested (and there are some TODO notes such as handling of all possible errors). It would be nice to test it against some real-world BOMs with large portion of partnumbers available at TME. Also, I made the code dependent on the requests module for AJAX requests; this might be redundant as some of the already used modules might be able to do the same thing.

The API requires registration and API key, which might be unwanted for this kind of application (each user would have to obtain her own API key as the key shall not be shared according to the documentation).

@hildogjr I'm affraid that this should be done by someone with deeper knowledge of both Python and KiCost internals...

@hildogjr
Copy link
Owner

@maciekKuba , yes, I total agree, Because this I preferred propose in the forum and not in my pull request. I jut think that if they standardize all, make more easy to us add new module (if you see the __main__.py in the rs, mouser... folders, do not have function).

@hildogjr
Copy link
Owner

hildogjr commented Oct 5, 2017

Closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New features resquested.
Projects
None yet
Development

No branches or pull requests

3 participants