Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning componentWillReceiveProps has been renamed #72

Open
Junhano opened this issue Nov 11, 2020 · 2 comments
Open

Warning componentWillReceiveProps has been renamed #72

Junhano opened this issue Nov 11, 2020 · 2 comments

Comments

@Junhano
Copy link

Junhano commented Nov 11, 2020

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

I think react native numeric input needs a fix? Since the function has been renamed by React Native

@kussberg
Copy link

kussberg commented Jan 7, 2021

Same thing.

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: %s, NumericInput

@kussberg
Copy link

kussberg commented Jan 7, 2021

There is fixed patched version here: https://www.npmjs.com/package/rn-numeric-input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants