Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated useEffect dependencies to reinitialize when a prop has changed #107

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Updated useEffect dependencies to reinitialize when a prop has changed #107

merged 2 commits into from
Feb 28, 2022

Conversation

kevinfarrugia
Copy link
Owner

@kevinfarrugia kevinfarrugia commented Feb 28, 2022 •
edited
Loading

What's Changing

  • Added optional id prop which will be included in the DOM and used for auto-generated arrows and dots.
  • Improved stability by reinitializing Glider whenever props (including event handlers) change.
  • Updated type definitions.

Dev Notes

  • Replaced tslint with eslint

Closes #106.

@kevinfarrugia kevinfarrugia added the patch create a patch release label Feb 28, 2022
@kevinfarrugia kevinfarrugia merged commit b9f7e4f into master Feb 28, 2022
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v3.0.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch create a patch release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glider is not reinitialized after event handlers are updated
2 participants
@kevinfarrugia @hipstersmoothie