Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type definitions for events #64

Merged
merged 3 commits into from
May 26, 2021
Merged

Update type definitions for events #64

merged 3 commits into from
May 26, 2021

Conversation

kevinfarrugia
Copy link
Owner

@kevinfarrugia kevinfarrugia commented May 24, 2021

What's Changing

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

I have marked it as major because there is a change to the type definition, which should be classified as a breaking change; however this seems to have been there from some time.

@hipstersmoothie hipstersmoothie added the patch create a patch release label May 26, 2021
@hipstersmoothie hipstersmoothie merged commit 5d72b76 into kevinfarrugia:master May 26, 2021
@hipstersmoothie
Copy link
Collaborator

Downgraded to patch cause it's def a bug fix

@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v2.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch create a patch release released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definitions for events are incorrect Showing undefined class on glider-slider on storybook example
2 participants