Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event listeners before Glider initialisation #65

Merged
merged 3 commits into from
May 26, 2021
Merged

Add event listeners before Glider initialisation #65

merged 3 commits into from
May 26, 2021

Conversation

kevinfarrugia
Copy link
Owner

What's Changing

Fixes #61 .

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@kevinfarrugia kevinfarrugia mentioned this pull request May 24, 2021
Closed
@kevinfarrugia
Copy link
Owner Author

The issue was caused because the events are bound after the Glider is instantiated. As a result, the onLoad event would never be called even if the glider-loaded event is fired and onSlideVisible wouldn't be fired for the first set of slides. Subsequent events were firing normally.

@hipstersmoothie hipstersmoothie added the minor create a minor release label May 26, 2021
@hipstersmoothie hipstersmoothie merged commit f165472 into kevinfarrugia:master May 26, 2021
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v2.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor create a minor release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None of the Glider events fire.
2 participants
@kevinfarrugia @hipstersmoothie