Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running setup.py causes bug in Python 3 #6

Closed
Zardinality opened this issue Feb 24, 2018 · 1 comment
Closed

running setup.py causes bug in Python 3 #6

Zardinality opened this issue Feb 24, 2018 · 1 comment

Comments

@Zardinality
Copy link

Zardinality commented Feb 24, 2018

running setup.py in the root path of this repo showing:

Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    import neural_renderer
  File "/new_disk_1/antonio/neural_renderer/neural_renderer/__init__.py", line 1, in <module>
    from cross import cross
ModuleNotFoundError: No module named 'cross'

I changed all absolute imports to relative ones in the regarding file and it did the work, now ./neural_renderer/__init__.py looks like:

from .cross import cross
from .get_points_from_angles import get_points_from_angles
from .lighting import lighting
from .load_obj import load_obj
from .look import look
from .look_at import look_at
from .mesh import Mesh
from .optimizers import Adam
from .perspective import perspective
from .rasterize import (
    rasterize_rgbad, rasterize, rasterize_silhouettes, rasterize_depth, use_unsafe_rasterizer, Rasterize)
from .renderer import Renderer
from .save_obj import save_obj
from .vertices_to_faces import vertices_to_faces

__version__ = '1.1.2'

Adding ./neural_renderer to $PYTHON_PATH temporarily should do the same thing. I just feel this is worth a note in README.

@Zardinality Zardinality changed the title running setup.py cause bug in Python 3 running setup.py causes bug in Python 3 Feb 24, 2018
@hiroharu-kato
Copy link
Owner

Thank you for the useful suggestion!
I added this problem and solution to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants