Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip expensive view refreshes when not streaming new blocks #116

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

rafaelcr
Copy link
Collaborator

This PR skips expensive inscription count materialized views when the chainhook node is not streaming new blocks (i.e. not caught up to chain tip) so we can have faster data replays. A future PR would reflect this change in the status endpoint so it doesn't show it as "ready" if it's not streaming.

Also, this PR adds an ENV that will allow us to skip automatic predicate registrations so we can run things manually if we need to.

@rafaelcr rafaelcr temporarily deployed to Preview June 30, 2023 15:23 — with GitHub Actions Inactive
@github-actions
Copy link

Vercel deployment URL: https://ordinals-b987vykm5-blockstack.vercel.app 🚀

@rafaelcr rafaelcr requested a review from csgui June 30, 2023 16:56
Copy link

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rafaelcr rafaelcr merged commit baec17c into master Jun 30, 2023
@rafaelcr rafaelcr deleted the feat/streaming branch June 30, 2023 17:43
blockstack-devops pushed a commit that referenced this pull request Jun 30, 2023
## [0.4.1](v0.4.0...v0.4.1) (2023-06-30)

### Bug Fixes

* skip expensive view refreshes when not streaming new blocks ([#116](#116)) ([baec17c](baec17c))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

g0drlc added a commit to g0drlc/btc-ordinals-api that referenced this pull request Jul 14, 2024
## [0.4.1](hirosystems/ordinals-api@v0.4.0...v0.4.1) (2023-06-30)

### Bug Fixes

* skip expensive view refreshes when not streaming new blocks ([#116](hirosystems/ordinals-api#116)) ([baec17c](hirosystems/ordinals-api@baec17c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants