Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse chainhooks satpoint to get offset #69

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

rafaelcr
Copy link
Collaborator

Fixes #54

@rafaelcr rafaelcr requested a review from lgalabru May 12, 2023 16:52
@rafaelcr rafaelcr temporarily deployed to Preview May 12, 2023 16:52 — with GitHub Actions Inactive
@github-actions
Copy link

Vercel deployment URL: https://ordinals-hbulbqj7e-blockstack.vercel.app 🚀

@markmhendrickson
Copy link

@rafaelcr curious if this fix is ready and just awaiting review? Any way it can get expedited, since it seems to be impacting all new inscriptions for users in the wallet and preventing them from sending?

cc @314159265359879

@314159265359879
Copy link

Thanks for building a fix for this Rafael, quiet a few wallet users are looking forward to the fix for #54

output: `${tx_id}:0`,
offset: reveal.ordinal_offset.toString(),
output: `${satpoint.tx_id}:${satpoint.vout}`,
offset: satpoint.offset ?? null,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null or 0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC chainhooks returns this as null if the satpoint gets spent as fees? Or do I have that wrong?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right, perfect. That works, but we'll revisit this behavior chainhook side. Thanks!

Copy link

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one feedback on the null / 0 handling.

@rafaelcr rafaelcr merged commit 73580fb into develop May 18, 2023
@rafaelcr rafaelcr deleted the fix/satpoint branch May 18, 2023 16:33
@smcclellan smcclellan added this to the Q2-2023 milestone May 18, 2023
blockstack-devops pushed a commit that referenced this pull request May 19, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-05-19)

### Features

* add endpoint to retrieve all inscription transfers per block ([#63](#63)) ([e1afa7d](e1afa7d))
* add typescript client library ([#58](#58)) ([23e48f1](23e48f1))

### Bug Fixes

* parse chainhooks satpoint to get offset ([#69](#69)) ([73580fb](73580fb))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

g0drlc added a commit to g0drlc/btc-ordinals-api that referenced this pull request Jul 14, 2024
## [0.2.0](hirosystems/ordinals-api@v0.1.2...v0.2.0) (2023-05-19)

### Features

* add endpoint to retrieve all inscription transfers per block ([#63](hirosystems/ordinals-api#63)) ([e1afa7d](hirosystems/ordinals-api@e1afa7d))
* add typescript client library ([#58](hirosystems/ordinals-api#58)) ([23e48f1](hirosystems/ordinals-api@23e48f1))

### Bug Fixes

* parse chainhooks satpoint to get offset ([#69](hirosystems/ordinals-api#69)) ([73580fb](hirosystems/ordinals-api@73580fb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

API gives a wrong offset value for some ordinals
6 participants