-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse chainhooks satpoint to get offset #69
Conversation
Vercel deployment URL: https://ordinals-hbulbqj7e-blockstack.vercel.app 🚀 |
@rafaelcr curious if this fix is ready and just awaiting review? Any way it can get expedited, since it seems to be impacting all new inscriptions for users in the wallet and preventing them from sending? |
Thanks for building a fix for this Rafael, quiet a few wallet users are looking forward to the fix for #54 |
output: `${tx_id}:0`, | ||
offset: reveal.ordinal_offset.toString(), | ||
output: `${satpoint.tx_id}:${satpoint.vout}`, | ||
offset: satpoint.offset ?? null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null or 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC chainhooks returns this as null if the satpoint gets spent as fees? Or do I have that wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you're right, perfect. That works, but we'll revisit this behavior chainhook side. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one feedback on the null
/ 0
handling.
## [0.2.0](v0.1.2...v0.2.0) (2023-05-19) ### Features * add endpoint to retrieve all inscription transfers per block ([#63](#63)) ([e1afa7d](e1afa7d)) * add typescript client library ([#58](#58)) ([23e48f1](23e48f1)) ### Bug Fixes * parse chainhooks satpoint to get offset ([#69](#69)) ([73580fb](73580fb))
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [0.2.0](hirosystems/ordinals-api@v0.1.2...v0.2.0) (2023-05-19) ### Features * add endpoint to retrieve all inscription transfers per block ([#63](hirosystems/ordinals-api#63)) ([e1afa7d](hirosystems/ordinals-api@e1afa7d)) * add typescript client library ([#58](hirosystems/ordinals-api#58)) ([23e48f1](hirosystems/ordinals-api@23e48f1)) ### Bug Fixes * parse chainhooks satpoint to get offset ([#69](hirosystems/ordinals-api#69)) ([73580fb](hirosystems/ordinals-api@73580fb))
Fixes #54