Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pc types to allow strict type checking #1494

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

timechainz
Copy link
Contributor

Remove @internal on types that are used in exported functions to allow strict type validation.

Screenshot 2023-05-05 at 8 21 36 AM

Remove @internal on types that are used in exported functions to allow strict type validation.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:37am

@sabbyanandan
Copy link

@timechainz: Great to see this! Thank you for your proposal; we will review shortly.

@sabbyanandan sabbyanandan requested a review from janniks June 16, 2023 14:43
@janniks janniks changed the title Update pc.ts to allow strict type checking fix: update pc types to allow strict type checking Jul 5, 2023
@janniks janniks merged commit b916ef0 into hirosystems:master Jul 5, 2023
@janniks
Copy link
Collaborator

janniks commented Jul 5, 2023

Thanks for the contribution 🙏

This was referenced Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants