fix(notice): fix limit 1 on useNotice does not work

yamada-ui · Feb 6, 2024 · 6b9dc0a · 6b9dc0a
1 parent f90795f
commit 6b9dc0a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/swift-rice-develop.md b/.changeset/swift-rice-develop.md
@@ -0,0 +1,5 @@
+---
+"@yamada-ui/notice": patch
+---
+
+fix limit 1 on useNotice does not work
diff --git a/packages/components/notice/src/notice.tsx b/packages/components/notice/src/notice.tsx
@@ -220,16 +220,20 @@ const createNoticeStore = (initialState: State): Store => {
     },
 
     create: (message, options) => {
-      const limit = (options.limit ?? 0) - 1
+      const limit = options.limit
 
       const notice = createNotice(message, options)
       const { placement, id } = notice
 
       setState((prev) => {
         let prevNotices = prev[placement] ?? []
 
-        if (limit > 0 && prevNotices.length > limit) {
-          const n = prevNotices.length - limit
+        if (
+          limit !== undefined &&
+          limit > 0 &&
+          prevNotices.length > limit - 1
+        ) {
+          const n = prevNotices.length - (limit - 1)
           const notices = placement.includes("top")
             ? prevNotices.slice(n * -1)
             : prevNotices.slice(0, n)