Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added isRounded to the button #766

Merged
merged 4 commits into from
Feb 21, 2024
Merged

feat: added isRounded to the button #766

merged 4 commits into from
Feb 21, 2024

Conversation

zvolcsey
Copy link
Contributor

Closes #759

Description

I added isRounded to the ButtonOptions type.
I added the appropriate css style.
I removed isRounded from IconButton, because it inherited from Button

Current behavior (updates)

IconButton has the isRounded props.

New behavior

isRounded inherited from the Button

Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: f2dc6cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@yamada-ui/button Patch
@yamada-ui/calendar Patch
@yamada-ui/carousel Patch
@yamada-ui/color-picker Patch
@yamada-ui/file-button Patch
@yamada-ui/modal Patch
@yamada-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

108yen
108yen previously approved these changes Feb 21, 2024
@hirotomoyamada
Copy link
Member

@zvolcsey

Hi, thanks for the PR.

Please run pnpm changeset and select patch.

@hirotomoyamada hirotomoyamada dismissed 108yen’s stale review February 21, 2024 04:23

Notfound the changeset file.

umaidashi
umaidashi previously approved these changes Feb 21, 2024
Copy link
Contributor

@umaidashi umaidashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@zvolcsey
Copy link
Contributor Author

@hirotomoyamada Hi! I added changeset to the PR.

@hirotomoyamada hirotomoyamada merged commit a6fb749 into yamada-ui:main Feb 21, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconButton has isRounded, but Button does not.
4 participants