Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranging Album not working #177

Closed
digitalsigi opened this issue Oct 31, 2019 · 11 comments
Closed

Rearranging Album not working #177

digitalsigi opened this issue Oct 31, 2019 · 11 comments

Comments

@digitalsigi
Copy link

Hi,
we are running Lightbox Gallery 1.12.0 on DNN 9.3.2 and quite happy with it. Thx for this piece of Software!
Only Issue: When rearranging the Album Order, the submit button does not work. Just nothing happens, no entry in Eventlog.
What can I do to get more information and solve problem?
Josef

@digitalsigi digitalsigi changed the title Rearranging Album Order not working Rearranging Album not working Oct 31, 2019
@digitalsigi
Copy link
Author

Updated to DNN 9.4.1, still same problem. But now I got an error entry in Eventlog. See attached file.
Josef
errorlog.zip

@digitalsigi
Copy link
Author

Got some more Info:
JQMIGRATE: jQuery.fn.bind() is deprecated
JQMIGRATE: jQuery.unique is deprecated, use jQuery.uniqueSort
not found: DesktopModules/WillStrohl.LightBoxGallery/js/images/ui-bg_glass_40_111111_1x400.png

and more.
How to overcome this?
To be honest, I have no working DNN development environment....
Plse help.

@edisfera
Copy link

edisfera commented Sep 7, 2020

There is a jQuery error complaining about .live not being a function (and this is preventing the two buttons from working).
I fixed the error buy replacing .live with .on in the following files located in /DesktopModules/WillStrohl.LightboxGallery: ChangeImageOrder.ascx (lines 26 and 39), ChangeOrder.ascx (lines 26 and 39) and the problem was solved.

@digitalsigi
Copy link
Author

Thx a lot for this! This is already an improvement, but now the two buttons are not visible and the Image is displayed as full screen.

@edisfera
Copy link

edisfera commented Sep 8, 2020

I did the same changes on my website and had no problem with buttons and images... if you change the .on back to .live does it revert back the button and image issue?

@WillStrohl
Copy link
Owner

Wow... It's great to see that people are still using this module. I had no idea! :D

I'll take a look into this as soon as I can.

@digitalsigi
Copy link
Author

I did the same changes on my website and had no problem with buttons and images... if you change the .on back to .live does it revert back the button and image issue?

OK. Rearraning works now.
However I am running DNN 9.4.1 and digging futher into problem I found that I was talking about another problem which is related to showing the gallery. There I have two issues:

  1. jquery.fancybox-1.3.4.pack.js:18 Uncaught TypeError: Cannot read property 'msie' of undefined
  2. Uncaught TypeError: jQuery(...).fancybox is not a function

See attached browser log
www.burckhardia.at-1599643512569.log

What can I do to fix this?

@edisfera
Copy link

edisfera commented Sep 9, 2020

I am running on DNN 9.6.1 and the version of fancybox is 3.5.7. If I were you I would update DNN first to a more recent version to see if this fixes the problem and/or update fancybox to a later version. Alternatively you can also wait for Will to look in to the original issue and see if he can address this issue too in the fix.

@digitalsigi
Copy link
Author

@edisfera Thx for followup.
I came to same conclusion, I'll first update, and see what the result is.
@hismightiness Yeah, the members of our club like it. They can upload their pictures and have a simple and nice gallery ...

WillStrohl added a commit that referenced this issue Sep 13, 2020
This was referenced Sep 13, 2020
@WillStrohl
Copy link
Owner

This issue was much more than just changing the jQuery method. It took all day today and I thought I'd be done in an hour. 🤣

https://github.com/hismightiness/dnnextensions/releases/tag/LBGallery-01.13.00

Thanks again for using the module and reporting the issue!

@digitalsigi
Copy link
Author

@hismightiness Thx a lot for your effort. It works.
Will there be another update for DNN 9.6+?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants