Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade elasticsearch-oss to 7.9.1 & ODFE to the latest version (1.10.1) #1719

Closed
rafzei opened this issue Oct 1, 2020 · 5 comments
Closed
Assignees
Labels
priority/high Task with high priority type/bug
Milestone

Comments

@rafzei
Copy link
Contributor

rafzei commented Oct 1, 2020

Describe the bug
During testing I found this regression bug in Elasticsearch v7.8.0. It was fixed in ES 7.8.1, see PR.

To Reproduce
Steps to reproduce the behavior:
It's not possible to upgrade only Elasticsearch without Open Distro for Elasticsearch, for example:

apt-get install opendistro-alerting
The following packages have unmet dependencies:\n opendistro-alerting : Depends: elasticsearch-oss (= 7.8.0) but 7.8.1 is to be installed
E: Unable to correct problems, you have held broken packages.

Expected behavior
Successful installation.

Config files
No.

OS (please complete the following information):

  • OS: All

Cloud Environment (please complete the following information):

  • Cloud Provider: All

Additional context
ODFE just released new version (1.10.1), see here.

Originally posted by @to-bar in #1140 (comment)

@rafzei rafzei added this to the S20201022 milestone Oct 1, 2020
@rafzei rafzei changed the title [BUG] Upgrade ODFE to latest version (1.10.1) [BUG] Upgrade ODFE to the latest version (1.10.1) Oct 1, 2020
@rafzei rafzei modified the milestones: S20201022, S20201008 Oct 1, 2020
@rafzei rafzei self-assigned this Oct 5, 2020
@mkyc
Copy link
Contributor

mkyc commented Oct 6, 2020

This task fixes issue introduced in #1140

@rafzei
Copy link
Contributor Author

rafzei commented Oct 7, 2020

On block because of #1741

@mkyc mkyc modified the milestones: S20201008, S20201022 Oct 8, 2020
@to-bar
Copy link
Contributor

to-bar commented Oct 9, 2020

With PR #1718 we have introduced Jinja template for jvm.options file. This file defines JVM heap size (Xmx). The default is 1 GB but Elasticsearch doc says:

When moving to production, it is important to configure heap size to ensure that Elasticsearch has enough heap available.

So it is very likely that one could increase the JVM heap size. But for epicli upgrade we do not support defining custom values for new configuration settings. The setting specification.jvm_options has been introduced in v0.8.0rc1.
Current code (for upgrades) always uses the default value, i.e 1 GB (see PR #1763), so any customized value is overwritten during the upgrade. To solve this issue we can try to get the existing setting from remote host (from jvm.options file) to preserve the custom value instead of overwriting it with the default.

More info: https://www.elastic.co/guide/en/elasticsearch/reference/7.9/heap-size.html

This JVM heap size issue can be solved in separate PR.

@rafzei rafzei changed the title [BUG] Upgrade ODFE to the latest version (1.10.1) [BUG] Upgrade elasticsearch-oss to 7.9.1 & ODFE to the latest version (1.10.1) Oct 14, 2020
@mkyc mkyc modified the milestones: S20201022, S20201105 Oct 22, 2020
@mkyc mkyc added priority/high Task with high priority and removed priority/critical-urgent labels Oct 23, 2020
@rafzei
Copy link
Contributor Author

rafzei commented Oct 26, 2020

@przemyslavic @to-bar Was it tested? If so, please move it to the correct column.

@przemyslavic
Copy link
Collaborator

Tested mainly by @to-bar.

@mkyc mkyc closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high Task with high priority type/bug
Projects
None yet
Development

No branches or pull requests

5 participants