Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Convert report_to from Checkbox to Dropdown in webUI #6662

Closed
steveepreston opened this issue Jan 15, 2025 · 1 comment · Fixed by #6688
Closed

[Feature] Convert report_to from Checkbox to Dropdown in webUI #6662

steveepreston opened this issue Jan 15, 2025 · 1 comment · Fixed by #6688
Labels
solved This problem has been already solved

Comments

@steveepreston
Copy link
Contributor

steveepreston commented Jan 15, 2025

Problem:

While report_to in transformers/training_args.py is:

report_to (`str` or `List[str]`, *optional*, defaults to `"all"`):
                The list of integrations to report the results and logs to. Supported platforms are `"azure_ml"`,
                `"clearml"`, `"codecarbon"`, `"comet_ml"`, `"dagshub"`, `"dvclive"`, `"flyte"`, `"mlflow"`,
                `"neptune"`, `"tensorboard"`, and `"wandb"`. Use `"all"` to report to all integrations installed,
                `"none"` for no integrations.

But report_to in LLaMA-Factory WebUI is:

report_to="all" if get("train.report_to") else "none",

Related issue: #6660


Proposal:

Make report_to Select Instead of Checkbox in WebUI. Example:

image

Pull Request

No response

@steveepreston steveepreston added enhancement New feature or request pending This problem is yet to be addressed labels Jan 15, 2025
@steveepreston steveepreston changed the title [Feature] Convert report_to from Select to Checkbox in webUI [Feature] Convert report_to from Checkbox to Select in webUI Jan 15, 2025
@hiyouga hiyouga mentioned this issue Jan 17, 2025
2 tasks
@hiyouga hiyouga added solved This problem has been already solved and removed enhancement New feature or request pending This problem is yet to be addressed labels Jan 17, 2025
@steveepreston steveepreston changed the title [Feature] Convert report_to from Checkbox to Select in webUI [Feature] Convert report_to from Checkbox to Dropdown in webUI Jan 18, 2025
@steveepreston
Copy link
Contributor Author

@hiyouga Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants