Replies: 1 comment
-
Seems like a well thought out plan. If you can find time to put up a PR it I'd appreciate it! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Currently, running
pvm install 8.3
installs 8.3.13. However, the newest version on the 8.3.x branch is actually 8.3.14.The problem is that this program only looks at the downloads listed at https://windows.php.net/downloads/releases/archives/
This list never includes the newest version.
The same is true about 8.4.x - the newest is 8.4.1, but this program can only download 8.4.0.
I think there is a simple fix for this: always check for the requested version at https://windows.php.net/downloads/releases/ before checking https://windows.php.net/downloads/releases/archives/
Here's how this helps:
.../releases/
A possible additional optimization could be to check https://windows.php.net/downloads/releases/releases.json instead of parsing the directory listing of the
releases
directory. That would mean there would be no need to filter out the "debug", "devel", and "test" downloads. Then check thearchives
directory only for explicitly-requested patch versions that aren't in the JSON file.I'm going to try to find some time for a PR for this, but I was curious if anyone has any thoughts on it first.
Beta Was this translation helpful? Give feedback.
All reactions