Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ping measurement to Get-SteamServerInfo #100

Closed
ericwong3 opened this issue Jun 12, 2024 · 1 comment · Fixed by #101
Closed

Add Ping measurement to Get-SteamServerInfo #100

ericwong3 opened this issue Jun 12, 2024 · 1 comment · Fixed by #101
Labels
Category-Module Pertaining to the module's functionality itself. Issue-Enhancement ✨ Make it better! Issue-Suggestion This should be added!

Comments

@ericwong3
Copy link
Contributor

Describe "Functionality"

Enhance Get-SteamServerInfo to measure the ping/patency.

Context "Private or Public? What are the use cases? Parameters? Options?"

Public. This would be very helpful for building user facing application, as latency is a deciding factor for players whether a server is playable or not.

Context "Additional Information"
@ericwong3 ericwong3 added Category-Module Pertaining to the module's functionality itself. Issue-Suggestion This should be added! labels Jun 12, 2024
@ericwong3 ericwong3 mentioned this issue Jun 12, 2024
Merged
10 tasks
@ericwong3
Copy link
Contributor Author

ericwong3 commented Jun 12, 2024 •
edited
Loading

Thank you for the good work @hjorslev ! This is my first PR for open source projects so please bear with me if I have got an etiquette wrong. Hopefully the suggestion makes sense and the PR is up to standard. Appreciated!

@hjorslev hjorslev added the Issue-Enhancement ✨ Make it better! label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category-Module Pertaining to the module's functionality itself. Issue-Enhancement ✨ Make it better! Issue-Suggestion This should be added!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ping measurement to Get-SteamServerInfo
2 participants
@ericwong3 @hjorslev