Ensure govuk modules import the actual window

hmcts · Mar 7, 2018 · cf93247 · cf93247
1 parent 15d1f5e
commit cf93247
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/sources/govukToolkit.js b/src/sources/govukToolkit.js
@@ -20,7 +20,8 @@ const govukModule = (file, expose, imports = ['window.jQuery=jquery']) => {
   return {
     test: path.resolve(javascripts, file),
     use: [
-      `imports-loader?${importsArr.join(',')}`,
+      // All govuk modules attach to window and so need window imported
+      `imports-loader?${['window=window', ...importsArr].join(',')}`,
       `exports-loader?${exposeArr.join(',')}`
     ]
   };

diff --git a/src/webpack.js b/src/webpack.js
@@ -33,6 +33,7 @@ const webpackSettings = (assetPath, settings) => {
       path: path.resolve('./dist'),
       filename: '[name].js'
     },
+    externals: [{ window: 'window' }],
     module: {
       rules: [
         ...browserSupport,