Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H1 in legend not available using shortcut key or elements list dialog with JAWS #34

Open
shabana-ali opened this issue Jul 10, 2020 · 11 comments
Labels
assistive tech Assistive technology may be misbehaving jaws Audit task: use the JAWS screen reader windows Platform: Windows 10

Comments

@shabana-ali
Copy link
Contributor

E.g. https://design-system.service.gov.uk/patterns/dates/default/index.html

@shabana-ali shabana-ali added assistive tech Assistive technology may be misbehaving windows Platform: Windows 10 jaws Audit task: use the JAWS screen reader labels Jul 10, 2020
@adamliptrot-oc
Copy link
Contributor

Also an issue with Chrome (JAWS 2020)
Screenshot 2020-09-30 at 09 43 50

@adamliptrot-oc
Copy link
Contributor

adamliptrot-oc commented Sep 30, 2020

@shabana-ali found that the removal of the overflow: hidden rule from the legend fixes this (confirmed in Chrome with JAWS 2020).
However this was added as a fix to a bug in webkit browsers which collapses margins on legends. Removing this will cause headings inside legends to lose their margin and so lose the spacing between them and following content.
This rule is being added by GovUK Elements:

// Hack to let legends or elements within legends have margins in webkit browsers
legend {
  overflow: hidden;
}

https://github.com/alphagov/govuk_elements/blob/master/assets/sass/elements/_forms.scss#L33

There is an alternative fix for the one provided in Elements:

legend + * {
  -webkit-margin-collapse: separate;
}

necolas/normalize.css#168

But this only seems to work if the contained element's margin is known in advance so it can be added to the legend.

More investigation required.

@adamliptrot-oc
Copy link
Contributor

It looks like in Gov Frontend the margins are now placed on the legend itself rather than allowing the contained elements to set them, which would likely be the long-term fix for this.

@adamliptrot-oc adamliptrot-oc changed the title H1 in legend not available using shortcut key or elements list dialog in IE11 with JAWS H1 in legend not available using shortcut key or elements list dialog with JAWS Oct 2, 2020
@adamliptrot-oc
Copy link
Contributor

Created test page at https://liptrot.org/demos/legends/

Results:

JAWS 2020 and JAWS 2019

  • IE11 headings were not exposed at all in either case
  • Chrome and Edge headings were exposed only in the second example

JAWS 2018

headings were exposed in all cases in all browsers

@chrismoorembe
Copy link

chrismoorembe commented Oct 2, 2020 via email

@adamliptrot-oc
Copy link
Contributor

Reported as a bug in JAWS to Freedom Scientific.

@adamliptrot-oc
Copy link
Contributor

Freedom Scientific have recorded bug as 117537 and development team are investigating.

@adamliptrot-oc
Copy link
Contributor

Related: w3c/html-aria#350

@adamliptrot-oc
Copy link
Contributor

alphagov/govuk-frontend#1605 (comment)

update from Freedom Scientific which suggests that this bug will be looked at as part of their 2022 cycle (i.e: released as an update at some point to version 2022).

@ashfaqhussain357
Copy link

To be tested with Jaws 2022 and update findings here.

@ashfaqhussain357
Copy link

Issue resolved in Jaws 2022.

@ashfaqhussain357 ashfaqhussain357 moved this to In progress in Investigation Jul 16, 2024
@ashfaqhussain357 ashfaqhussain357 moved this from In progress to Done in Investigation Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assistive tech Assistive technology may be misbehaving jaws Audit task: use the JAWS screen reader windows Platform: Windows 10
Projects
Status: Done
Development

No branches or pull requests

4 participants