Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMRC banner #4

Closed
5 tasks
gavinwye opened this issue Jan 27, 2017 · 11 comments
Closed
5 tasks

HMRC banner #4

gavinwye opened this issue Jan 27, 2017 · 11 comments

Comments

@gavinwye
Copy link
Contributor

gavinwye commented Jan 27, 2017

This will more than likely be a child of the GOV.UK header

To Do

  • content review of the pattern description
  • code review of example markup
  • assessability review of examples
  • add a skip link to the header examples
  • add role="main" to the main element

Screenshots

These are the screenshots that are live today collected here for reference.

Desktop versions

Personal tax account

personal-tax-account-header

Business tax account

bussiness-tax-account-header

Mobile versions

Personal tax account

personal-tax-account-header-mobile

Business tax account

business-tax-account-header-mobile

@gavinwye gavinwye mentioned this issue Jan 31, 2017
@gavinwye gavinwye removed the GOV.UK label Jul 11, 2017
@gavinwye gavinwye added the GOV.UK label Aug 9, 2017
@gavinwye gavinwye self-assigned this Aug 16, 2017
@gavinwye gavinwye removed the GOV.UK label Aug 18, 2017
@hmrc hmrc deleted a comment from vickytnz Aug 22, 2017
@gavinwye
Copy link
Contributor Author

See the latest work on this pattern in the design pattern library.

@gavinwye
Copy link
Contributor Author

There is a pull request open for this against Assets Frontend hmrc/assets-frontend#819

This was referenced Oct 20, 2017
Closed
@rpowis rpowis changed the title HMRC header Header Apr 12, 2018
@stevenaproctor
Copy link

@jennifer-hodgson This is the HMRC-specific extras to the GOV.UK header. Probably a good idea to rename it HMRC header. What do you think?

@jennifer-hodgson jennifer-hodgson changed the title Header HMRC header Oct 10, 2018
@mikeash82
Copy link

Moved to site header on GOV.UK issues backlog

@mikeash82 mikeash82 changed the title HMRC header HMRC banner Aug 13, 2020
@IxDradge
Copy link

Hi, this pattern seems to have a bug in it, when I apply the code the blue line under the header wraps awkwardly. I used the code:

{{ hmrcHeader({
  "serviceName": "Service Name",
  "serviceUrl" : "/",
  "phaseBanner" : true,
  "signOutHref" : "?sign-out"
}) }}

image

@IxDradge
Copy link

You can see the bug in the HMRC design system web page -
image

@timsb
Copy link

timsb commented Nov 10, 2021

You can see the bug in the HMRC design system web page - image

Thanks for raising @IxDradge. The reason this is showing up is because the phase banner parameter has been set to true but it has no content so is just being set to a collapsed blue box. I spotted this a while ago and wondered whether it was clear from the parameters that it was the case but seems not.

I'll add a story to our backlog to actually show a normal phase banner in the examples.

For now, if you aren't wanting to show the phase banner then you can just set it to false.

@IxDradge
Copy link

Ah got you, thanks. All working now.

@IxDradge
Copy link

Just one problem, I now can't over-write the service name on individual pages. The service name is set to what ever I call it in the layout.html file. I'd like to be able to over-write it on individual pages using this snippet -

{% set serviceName %}
Business tax account
{% endset%}

Any ideas? Thanks again.

@timsb
Copy link

timsb commented Nov 11, 2021

In the prototype kit this can be done by either creating multiple layout files or in each individual page view overwriting/redefining the header block.

@IxDradge
Copy link

Gotcha, many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants