Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Custom Layers in ImageLayer and MultiscaleImageLayer #424

Open
ilan-gold opened this issue May 3, 2021 · 0 comments
Open

Allow for Custom Layers in ImageLayer and MultiscaleImageLayer #424

ilan-gold opened this issue May 3, 2021 · 0 comments

Comments

@ilan-gold
Copy link
Collaborator

User story
ImageLayer and MultiscaleImageLayer both handle a lot of logic around the loader, tile sizes, doing the loading etc. but it would be nice (i.e for the bitmask use-case in Vitessce) to be able to just pass in a custom layer so you can re-use all the logic for these hairy things while still getting the ability to customize your rendering.

Preferred solution
Add a Layer prop to both ImageLayer and MultiscaleImageLayer.

Possible alternatives
Another possible solution, I think, would be to refactor the shaders to allow for custom rendering, although this would be problematic if you want to attach new uniform variables to the shader, which we do want to do for the bitmask layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant