Closing client from server closes other clients as well?

[undsoft]

Hello, my dear friends.

I need to say that it has been challenging trying to incorporate the library into a production environment :)

Scenario:

1. User A connects.
2. User B connects.
3. After some time when User B sends a message, and in onMessage handler, server decides to disconnect user A.
4. Server does:

$connection = $node->getConnection();

        $connection->close(
            Connection::CLOSE_NORMAL,
            $message
        );

where $node is the stored node of user A.

ER: User A is disconnected.
AR: Both users seem to lose the connection.

Upon debugging I can see that $node->getConnection()->close() goes to
Hoa\Stream\Stream->close() and to
Hoa\Socket\Server->_close(), which in turn gets current stream (User B, Mistake!) and fcloses it.

[undsoft]

Doing

/** @var Rfc6455 $protocol */
        $protocol = $node->getProtocolImplementation();

        $protocol->close(
            Connection::CLOSE_NORMAL,
            $message
        );

doesn't help, it still writes disconnect message to the current node, when I'm trying to remove the other node.

@fclose($node->getSocket());

This seems to be working, but probably bad code.

[Hywan]

Hello & sorry for the late reply, most of the team is AFK.

Are you able to provide me a code to reproduce your issue? Network issues are really hard to debug and to reproduce. I would bet that this usecase is already handled and something else is happening, and I would love to know what :-).

Thanks!

[Hywan]

cc @Pierozi

[undsoft]

@Hywan
https://github.com/undsoft/hoa-websocket-bug

[Hywan]

OK, I have a clue. Hard to explain, especially because I am sick and I am not sure. Will try to work on this issue the next couple of days. If you don't have any news from me, feel free to ping me :-).

[undsoft]

Bump

[Pierozi]

I think is directly retaled to the way we manage the Nodes, This PR could fix the issue but not sure
hoaproject/Socket#50

[marmotz]

Any news ?