Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of crates with wrong check results #4

Open
hobofan opened this issue Nov 13, 2018 · 3 comments
Open

List of crates with wrong check results #4

hobofan opened this issue Nov 13, 2018 · 3 comments
Labels
tracking This issue is tracking progress/interactions of some external dependencies

Comments

@hobofan
Copy link
Owner

hobofan commented Nov 13, 2018

Since the checks rely on currently somewhat limited mechanisms, it's probably a good idea to start compiling a list of where the checks yield wrong results. This then allows us to more targetly work towards improving the checks by having real-world test cases for them.

Contributions are highly welcome!

crates

rand_isaac:

repo: https://github.com/rust-random/rand
Wrongly identified as not supporting no_std because of non-trivial feature gate code:
#![cfg_attr(not(all(feature="serde1", test)), no_std)]

History

Support for libc has been fixed: See #1

@hobofan hobofan added the tracking This issue is tracking progress/interactions of some external dependencies label Jan 18, 2019
@hobofan hobofan pinned this issue Jan 28, 2019
@barafael
Copy link
Contributor

barafael commented Jun 2, 2021

at-commands:
repo: https://github.com/diondokter/at-commands
Wrongly identified as not suporting no_std because of just about non-trivial combination of feature gates:
#![cfg_attr(all(not(test), not(feature = "std")), no_std)]

@barafael
Copy link
Contributor

barafael commented Jun 2, 2021

num-traits:
repo: https://github.com/rust-num/num-traits
Wrongly accepted, but default features include std

@barafael
Copy link
Contributor

barafael commented Jun 2, 2021

sdp8xx-rs:
repo: https://github.com/barafael/sdp8xx-rs/tree/main/sdp8xx
file src/test.rs includes explicit use std;, but gated behind feature test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking This issue is tracking progress/interactions of some external dependencies
Projects
None yet
Development

No branches or pull requests

2 participants