Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add an event or hook in ContentNavigationBuilder->collect() #20

Open
Defcon0 opened this issue Jan 21, 2021 · 1 comment
Assignees

Comments

@Defcon0
Copy link

Defcon0 commented Jan 21, 2021

Hello,

at first thanks for the great plugin. It works like a charm 👍

Only one thing bothers me. I use https://github.com/heimrichhannot/contao-news-pagination-bundle which generates a pagination (automatically based on character length or manually based on wrapper content elements) in the parseArticles hook.

Hence the links would also need to respect the generated pagination. So I need to adjust the links generated in ContentNavigationBuilder->collect().

A hook or event would be enough for that.

Would that be an option? I could also create a PR for an event dispatch if you like. At the moment I need to override the content element or create a parseTemplate hook which is not very precise since I need to check for the template name.

Thanks in advance!

Bye Defcon0

@dmolineus
Copy link
Collaborator

Feel free to provide an PR for that. Please use an event insteadof a hook for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants