Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when the number of windows exceed a threshold #124

Open
EricR86 opened this issue Feb 21, 2018 · 5 comments
Open

Warn users when the number of windows exceed a threshold #124

EricR86 opened this issue Feb 21, 2018 · 5 comments
Labels
enhancement New feature or request minor

Comments

@EricR86
Copy link
Member

EricR86 commented Feb 21, 2018

Original report (BitBucket issue) by Mickaël Mendez (Bitbucket: Mickael Mendez).


A high number of windows can indicate an error in the way the inputs were processed and results in a very long training or annotation time.

Segway could print a warning message after calculating the windows if it's number exceed an unreasonnable threshold (maybe 10 000).

This enhancement was suggested by Michael Hoffman.

@EricR86
Copy link
Member Author

EricR86 commented Feb 22, 2018

Original comment by Eric Roberts (Bitbucket: ericr86, GitHub: ericr86).


Is there any consideration of what would be considered unreasonable? What if a user wants to train on a lot of specific regions (like GENCODE regions)?

What if a user wants to disable this warning?

Would printing out the number of windows before job submission be sufficient/better?

@EricR86
Copy link
Member Author

EricR86 commented Feb 22, 2018

Original comment by Michael Hoffman (Bitbucket: hoffman, GitHub: michaelmhoffman).


I was thinking 10000 windows. Printing out the number of windows before submitting jobs might help with this without necessitating an option to disable the warning or an un-disableable warning.

@EricR86
Copy link
Member Author

EricR86 commented Feb 23, 2018

Original comment by Eric Roberts (Bitbucket: ericr86, GitHub: ericr86).


After some discussion there was thoughts about changing the job submission log output to be in a rough format of:

"queued: world#, instance #, window # / total windows (full job name)"

@EricR86
Copy link
Member Author

EricR86 commented Feb 23, 2018

Original comment by Michael Hoffman (Bitbucket: hoffman, GitHub: michaelmhoffman).


How about "queued: world #/T, instance #/T, window #/T (full job name)"?

I think this will make diagnostics easier.

@EricR86
Copy link
Member Author

EricR86 commented Feb 23, 2018

Original comment by Eric Roberts (Bitbucket: ericr86, GitHub: ericr86).


I think that would probably be best.

@EricR86 EricR86 added minor enhancement New feature or request labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant