Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix module info missing requirement + not exporting #138

Merged
merged 1 commit into from
May 31, 2023
Merged

fix module info missing requirement + not exporting #138

merged 1 commit into from
May 31, 2023

Conversation

c-eg
Copy link
Owner

@c-eg c-eg commented May 27, 2023

After trying to use the updated (1.14 version) of this library, I ran into some errors. After checking I realised I forgot to export the parts of the library that should be public in my previous PR #136.

Changes:

  • Added export to all packages that should be usable when importing this module
  • Added a missing requires

Sorry for missing this.

@holgerbrandl holgerbrandl merged commit 2d6e5e9 into c-eg:master May 31, 2023
@holgerbrandl
Copy link
Collaborator

Thanks for the correction. I've published the change in v1.15 and pushed it to maven-central

@c-eg
Copy link
Owner Author

c-eg commented May 31, 2023

Thank you!

@c-eg c-eg deleted the modile_info_fix branch May 31, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants