Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscores used in determining parent regions conflict with regions that are named with underscores #110

Closed
ppeble opened this issue Nov 28, 2018 · 1 comment
Closed

Underscores used in determining parent regions conflict with regions that are named with underscores #110

ppeble opened this issue Nov 28, 2018 · 1 comment
Assignees
@ppeble
Labels
bug

Comments

@ppeble
Copy link
Member

ppeble commented Nov 28, 2018

This is a matching issue with holidays/holidays#331. This is a poorly defined edge case that we hope we solve. I will be submitting a PR to address it shortly.
@ppeble ppeble added the bug label Nov 28, 2018
@ppeble ppeble self-assigned this Nov 28, 2018
@ppeble ppeble mentioned this issue Nov 28, 2018
Merged
@ppeble
Copy link
Member Author

ppeble commented Dec 9, 2018

Fixed in referenced PR.

@ppeble ppeble closed this as completed Dec 9, 2018
@annaswims annaswims mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppeble ppeble

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppeble