Insteon: Sync Links is Incorrectly Storing Links in the MH Link Hash

[krkeegan]

As reported by Marc and Micheal:

I do seem to pick up a duplicate entry each time though.

Here's the log if that helps.
http://marc.merlins.org/tmp/mh_sync_link2/sync_link3

I have seen where there are discrepancies between what MH thinks it is syncing and what
the device actually contains. This could easily cause subsequent syncs to duplicate
entries. If you are curious you can reproduce the condition with the following sequence:
Sync links on a device (device needs to have new entries to sync)
Log links on that device
Scan links on that device
Log links on that device
Then do a diff of the link output between the two "log links" commands. When I do this I
see discrepancies in the group numbers. I'll dig into that issue and see what I find. It
will take me a while because I don't fully understand the metadata used to link devices;
the Insteon documents are vague in this area.

Sincerely,
Michael

[krkeegan]

I have tried this multiple times with the current Master branch and I cannot reproduce this.

Perhaps this was caused by some corrupt messages?? Hopefully the newer version of master will rectify this.

[mstovenour]

I think we have cleaned this up. I'll close it for now. If it reappears we can open a new issue to track it.