Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running master from zipfile gives fatal message #643

Closed
hollie opened this issue Dec 8, 2016 · 2 comments
Closed

Running master from zipfile gives fatal message #643

hollie opened this issue Dec 8, 2016 · 2 comments
Assignees
Labels

Comments

@hollie
Copy link
Owner

hollie commented Dec 8, 2016

As mentioned by Jeff via the mailing list: running misterhouse from the zipfile gives a fatal message at startup:

Deleting startup file
Running mh
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git

Command: mh

To reproduce:

  • download the zipfile for the master branch
  • extract, cd to misterhouse-master/bin
  • run 'mhl'

We probably need to check first if the .git folder exists before trying to do something with it.

@hollie hollie added the bug label Dec 8, 2016
@hollie hollie added this to the MisterHouse v4.2 milestone Dec 8, 2016
@hollie hollie self-assigned this Dec 8, 2016
@hollie
Copy link
Owner Author

hollie commented Dec 8, 2016

Hello,

after investigating this further, the code will actually work fine once it is released as a stable version. The code that gives the error only runs on non-stable versions...

I will however adapt it to check that the git folders actually exist to avoid running into this problem again for next versions.

@hollie hollie mentioned this issue Dec 8, 2016
@hollie
Copy link
Owner Author

hollie commented Dec 17, 2016

Should be fixed in master.

@hollie hollie closed this as completed Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant