Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Elm generation on CI #6

Closed
chshersh opened this issue Jan 23, 2019 · 2 comments · Fixed by #87
Closed

Test Elm generation on CI #6

chshersh opened this issue Jan 23, 2019 · 2 comments · Fixed by #87
Assignees
@chshersh
Labels
CI tests

Comments

@chshersh
Copy link
Contributor

They will be very useful!
@vrom911
Copy link
Contributor

vrom911 commented Feb 22, 2019

Or we can run generate-elm executable on CI and also run elm code?

@chshersh
Copy link
Contributor Author

@vrom911 That's great idea! I think we don't need golden tests for pretty printing. After thinking a little bit on this, I guess it doesn't make sense to check the formatting. We need to check that the code compiles. I like the idea of calling generate-elm executable on the CI and compiling elm package. We only need to figure out how to do this...

@chshersh chshersh changed the title Implement golden tests Test Elm generation on CI Feb 22, 2019
@chshersh chshersh self-assigned this Sep 3, 2019
chshersh added a commit that referenced this issue Sep 3, 2019
@chshersh
[#6] Test Elm build on CI
f4304c1 
Resolves #6
@chshersh chshersh mentioned this issue Sep 3, 2019
Merged
vrom911 pushed a commit that referenced this issue Sep 3, 2019
@vrom911
[#6] Test Elm build on CI (#87)
36cdf40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6] Test Elm build on CI Holmusk/elm-street
2 participants
@chshersh @vrom911