Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config flags are broken #551

Open
haritowa opened this issue Jul 11, 2023 · 3 comments
Open

Config flags are broken #551

haritowa opened this issue Jul 11, 2023 · 3 comments

Comments

@haritowa
Copy link

Expected Behavior

Flags are propagated to command and used instead of manual input

Current Behavior

Flags are ignored/leads to crash

How to reproduce (for bugs)

I tried different combinations and observed this:

  • url and network flags are ignored (pic 1, 2)
  • private key flag leads to crash (pic 3)

CleanShot 2023-07-11 at 6 40 54

CleanShot 2023-07-11 at 6 41 14

CleanShot 2023-07-11 at 6 41 39

My commands:

holograph config --url https://goerli.infura.io/v3/test --network goerli
holograph config --privateKey 0x8685b885aa42a6e614a5276ad57df05a8b7b6084695e2aef31830b29d0711eaa
@sogoiii
Copy link
Contributor

sogoiii commented Jul 11, 2023

@haritowa Ok thank you for this bug report. But please update your comment to remove your privateKey. I know this is just testnet accounts, but its good practice to always hide that.

@haritowa
Copy link
Author

haritowa commented Jul 11, 2023

@haritowa Ok thank you for this bug report. But please update your comment to remove your privateKey. I know this is just testnet accounts, but its good practice to always hide that.

This is throw away PK which I generated for this issue(no previous interactions/no tokens/no future interactions etc)

I am trying to provide "real world" examples which can be tested as is.
If you still think that I should remove it -- ping me again please

@haritowa
Copy link
Author

Same issue with faucet
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants