Skip to content

Commit 853e1c1

Browse files
authored
fix: Column updates not working for Bokeh < 3.7 (#7948)
1 parent 4d17528 commit 853e1c1

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

panel/models/column.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,10 @@ export class ColumnView extends BkColumnView {
167167
for (let i = 0; i < this.child_views.length; i++) {
168168
const view = this.child_views[i]
169169
const is_new = created_views.has(view)
170-
const target = view.rendering_target() ?? this.self_target
170+
// this.shadow_el is needed for Bokeh < 3.7.0 as this.self_target is not defined
171+
// can be removed when our minimum version is Bokeh 3.7.0
172+
// https://github.com/holoviz/panel/pull/7948
173+
const target = view.rendering_target() ?? this.self_target ?? this.shadow_el
171174
if (is_new) {
172175
view.render_to(target)
173176
} else if (matching_index === null || i > matching_index) {

panel/models/reactive_esm.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,10 @@ export class ReactiveESMView extends HTMLBoxView {
332332
this.render_esm()
333333
}
334334
for (const element_view of this.element_views) {
335-
const target = element_view.rendering_target() ?? this.self_target
335+
// this.shadow_el is needed for Bokeh < 3.7.0 as this.self_target is not defined
336+
// can be removed when our minimum version is Bokeh 3.7.0
337+
// https://github.com/holoviz/panel/pull/7948
338+
const target = element_view.rendering_target() ?? this.self_target ?? this.shadow_el
336339
element_view.render_to(target)
337340
}
338341
}

0 commit comments

Comments
 (0)