-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trend indicator #1895
Add Trend indicator #1895
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
==========================================
+ Coverage 84.58% 84.83% +0.24%
==========================================
Files 164 166 +2
Lines 19821 19987 +166
==========================================
+ Hits 16766 16956 +190
+ Misses 3055 3031 -24
Continue to review full report at Codecov.
|
Additional ContextThere is a video here https://discourse.holoviz.org/t/statsplotcard-pr/1689 After having studied the different "stats cards" out there I would say there are 3 archetypes
They can the be layed out either in a column or row format. |
One question is also if you @philippjfr would you rather merge in the responsize text and stackline plot as individual indicators and let the user compose it into the card he/ she needs? |
Right now the values I stream are strings because I don't know how the user would like to round, format and add units. That is flexible but also puts more work on the user. Is that how the api should be @philippjfr ? |
This looks really great; thanks @MarcSkovMadsen ! |
@jbednar Any opinions on naming this component? |
KPI? KPIPlot? KPICard? MetricCard? StatSummary? Too many possible names to pick just one! :-) |
3fa7b44
to
02177e6
Compare
Tbh now looking at this I think I am now consider whether it wouldn't be better split this into distinct indicators for the value and change text and the plot. |
Having them be separate is good, since each makes sense on its own, but having it be easy to instantiate as a complete unit is also convenient. |
In the recent HoloViz meeting I think we discussed ideas for better names than I suppose my only problem with that is that other indicators don't have Which might suggest it should simply be |
Hmm. |
I quite like |
If we want to be cute, |
I agree with the problem with |
4b8c2cf
to
aef9d65
Compare
The
Trend
indicator enables the user to display a Dashboard KPI Card withThe card can be layout out as
You can run the streaming test example below via
python -m panel serve 'panel\tests\widgets\test_stats_plot_card.py' --dev --show
Must do
row
layoutNice to do
description
to provide more info and context of the card. Maybe shown as tooltip or via click on card.text
div.