Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle integer column names on Perspective widget #2069

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2054

@hoxbro
Copy link
Member

hoxbro commented Mar 10, 2021

Do this change work with a dictionary like {0: [1,2,3], "0": [4,5,6]}?

If not, a check to _get_data to see that there is no overlapping dictionary keys like "0" and 0 is properly a good thing.

@philippjfr
Copy link
Member Author

Yes, we should check there's no overlap.

panel/pane/perspective.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2069 (3f18137) into master (8a233ca) will increase coverage by 0.01%.
The diff coverage is 91.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   84.43%   84.44%   +0.01%     
==========================================
  Files         178      179       +1     
  Lines       20636    20704      +68     
==========================================
+ Hits        17423    17484      +61     
- Misses       3213     3220       +7     
Impacted Files Coverage Δ
panel/pane/perspective.py 91.80% <88.09%> (+2.51%) ⬆️
panel/tests/pane/test_perspective.py 100.00% <100.00%> (ø)
panel/auth.py 39.51% <0.00%> (-0.37%) ⬇️
panel/viewable.py 72.38% <0.00%> (ø)
panel/tests/test_reactive.py 98.90% <0.00%> (+0.01%) ⬆️
panel/widgets/base.py 94.66% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a233ca...3f18137. Read the comment docs.

@philippjfr philippjfr merged commit 266f7ff into master Mar 12, 2021
@philippjfr philippjfr deleted the perspective_int_cols branch March 12, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perspective raises difficult to understand ValueError if data column is of type int
2 participants