Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes widget player loop when start is 0 #2141

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Fixes widget player loop when start is 0 #2141

merged 1 commit into from
Apr 5, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 3, 2021

Fixes #2140

If default parameters is not set, it sees 0 as Null. Default values are the same as the widgets.

playerwidget

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #2141 (f245398) into master (7410371) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
- Coverage   83.82%   83.80%   -0.02%     
==========================================
  Files         182      182              
  Lines       21637    21658      +21     
==========================================
+ Hits        18137    18151      +14     
- Misses       3500     3507       +7     
Impacted Files Coverage Δ
panel/models/widgets.py 100.00% <100.00%> (ø)
panel/io/notebook.py 54.83% <0.00%> (-2.54%) ⬇️
panel/widgets/slider.py 77.51% <0.00%> (-0.70%) ⬇️
setup.py 0.00% <0.00%> (ø)
panel/models/datetime_picker.py 100.00% <0.00%> (ø)
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/widgets/tables.py 84.18% <0.00%> (+0.32%) ⬆️
panel/reactive.py 75.67% <0.00%> (+0.60%) ⬆️
panel/pane/idom.py 48.83% <0.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7410371...f245398. Read the comment docs.

@philippjfr philippjfr merged commit 12d4994 into holoviz:master Apr 5, 2021
@hoxbro hoxbro deleted the fix_player_widget branch April 5, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player Widget does not loop when going forward, only backward
2 participants