Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RangeSlider value_start/value_end readonly #2468

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

philippjfr
Copy link
Member

Thanks @jbednar for catching this.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #2468 (217c35d) into master (668fad3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2468   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         184      184           
  Lines       23081    23082    +1     
=======================================
+ Hits        19222    19223    +1     
  Misses       3859     3859           
Impacted Files Coverage Δ
panel/widgets/slider.py 76.00% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668fad3...217c35d. Read the comment docs.

@philippjfr philippjfr merged commit 8e27d9f into master Jun 30, 2021
@philippjfr philippjfr deleted the readonly_range_slider branch June 30, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant