-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FloatPanel Status Change on Closure #5438
Comments
Wow. Are you using dtale with Panel? Could you share a minimum, reproducible example (on Discourse) (with the FloatPanel)? |
Added example to Discourse: FloatPanel with Dtale Session and Status Change on Closure. I followed another users example to get the dtale redirected through float panel: Can I use dtale in Panel?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
FloatPanel does not initiate a status change when clicking the close icon. I think it is due to JsPanel not sending a status change for close.
Example Solution
Add onbeforeclose option to config in _scripts:
onbeforeclose: function(panel, status, closedByUser) { data.status = 'closed' }
This should ensure that a status change is issued for closure.
Additional context
This feature would allow a watcher monitoring FloatPanel status to send an update on window closure. For example, I was running a dtale session with an html iframe pointing to the dtale session url inside of the floatpanel. I wanted to be able to kill the session when I close the floatpanel.
The text was updated successfully, but these errors were encountered: