Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatFeed tests are a bit flaky #5877

Closed
ahuang11 opened this issue Nov 15, 2023 · 5 comments
Closed

ChatFeed tests are a bit flaky #5877

ahuang11 opened this issue Nov 15, 2023 · 5 comments
Labels
TRIAGE Default label for untriaged issues

Comments

@ahuang11
Copy link
Contributor

Noting it down from #5875

FAILED panel/tests/chat/test_feed.py::TestChatFeed::test_send_with_respond - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_yield_chat_message_stream[None-None] - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_yield_chat_message_stream[C-Bob] - TimeoutError: wait_until timed out in 5000 milliseconds
@ahuang11 ahuang11 added the TRIAGE Default label for untriaged issues label Nov 15, 2023
@hoxbro
Copy link
Member

hoxbro commented Nov 15, 2023

Also some here https://github.com/holoviz/panel/actions/runs/6877056029/job/18703963441?pr=5866

FAILED panel/tests/chat/test_feed.py::TestChatFeed::test_respond_callback_returns_none - AssertionError: assert 'Testing!' == 'Mutated'
  - Mutated
  + Testing!
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_return_chat_message[C-Bob] - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_yield - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_callback_exception_raise - Failed: DID NOT RAISE <class 'ZeroDivisionError'>
FAILED panel/tests/io/test_cache.py::test_per_session_cache - ValueError: Callback functions must have signature func(session_context), got func(session_context=None)

@ahuang11
Copy link
Contributor Author

ahuang11 commented Nov 15, 2023

I wonder if we can just make timeout mseconds to 10000?

@ahuang11
Copy link
Contributor Author

ahuang11 commented Nov 15, 2023

@hoxbro
Copy link
Member

hoxbro commented Nov 15, 2023

I wonder if we can just make timeout mseconds to 10000?

It shouldn't take 5 seconds for a chat message to be updated. I think something is not being triggered, if that is the case, we will see the same thing when changing it to 10 seconds.

Running pytest panel/tests/chat -n logical --dist loadgroup:

I sometimes get this problem:
task: <Task pending name='Task-4' coro=<ChatFeed._prepare_response() running at /home/shh/Repos/holoviz/panel/panel/chat/feed.py:438> wait_for=<Future pending cb=[Task.task_wakeup()]> cb=[IOLoop.add_future.<locals>.<lambda>() at /home/shh/miniconda3/envs/holoviz/lib/python3.11/site-packages/tornado/ioloop.py:685]>

@ahuang11
Copy link
Contributor Author

I think this should be fixed now so closing. Please re-open if not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRIAGE Default label for untriaged issues
Projects
None yet
Development

No branches or pull requests

2 participants