-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChatFeed tests are a bit flaky #5877
Comments
Also some here https://github.com/holoviz/panel/actions/runs/6877056029/job/18703963441?pr=5866 FAILED panel/tests/chat/test_feed.py::TestChatFeed::test_respond_callback_returns_none - AssertionError: assert 'Testing!' == 'Mutated'
- Mutated
+ Testing!
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_return_chat_message[C-Bob] - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_yield - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/chat/test_feed.py::TestChatFeedCallback::test_callback_exception_raise - Failed: DID NOT RAISE <class 'ZeroDivisionError'>
FAILED panel/tests/io/test_cache.py::test_per_session_cache - ValueError: Callback functions must have signature func(session_context), got func(session_context=None) |
I wonder if we can just make timeout mseconds to 10000? |
If I had to take a guess, I suspect it's this that makes it flake: |
It shouldn't take 5 seconds for a chat message to be updated. I think something is not being triggered, if that is the case, we will see the same thing when changing it to 10 seconds. Running I sometimes get this problem: |
I think this should be fixed now so closing. Please re-open if not the case. |
Noting it down from #5875
The text was updated successfully, but these errors were encountered: