Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs and buttons in dark mode #1855

Closed
sophiamyang opened this issue Dec 18, 2020 · 2 comments · Fixed by #1919
Closed

tabs and buttons in dark mode #1855

sophiamyang opened this issue Dec 18, 2020 · 2 comments · Fixed by #1919
Labels
type: enhancement Minor feature or improvement to an existing feature
Milestone
v0.10.3

Comments

@sophiamyang
Copy link
Contributor

tab and buttons don't look great in dark mode. Maybe they could be brighter?
image
@MarcSkovMadsen
Copy link
Collaborator

Hi @sophiamyang .

The Panel templates with dark theme have not (yet) been styled in any way. That is something for the future. I also think its needed.

I've done at lot of the work for the FastTemplate and FastGridTemplate at awesome-panel.org. You can use them via pip install awesome-panel-extensions and from awesome_panel_extensions.frameworks.fast.templates import FastTemplate, FastGridTemplate.

@sophiamyang
Copy link
Contributor Author

@MarcSkovMadsen Looks amazing. Thanks so much!

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Dec 21, 2020
@philippjfr philippjfr mentioned this issue Jan 18, 2021
Merged
@philippjfr philippjfr added this to the v0.10.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
v0.10.3
Development

Successfully merging a pull request may close this issue.

Improve dark theme holoviz/panel
3 participants
@philippjfr @sophiamyang @MarcSkovMadsen