Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ToricVarieties_project to the homalg CI and "lines of code" #41

Closed
zickgraf opened this issue Jun 24, 2020 · 5 comments
Closed

Comments

@zickgraf
Copy link
Member

I have added some instructions to homalg_project describing how to do this: https://github.com/zickgraf/homalg_project/blob/56938ec8cb3cb681f784fea91ef751ce01702ae6/README_DEV.md

As a starting point for the tests you can look at the make targets ci-test and test-with-coverage in ToricVarieties/makefile, and my attempt to actually execute ci-test in the CI: zickgraf/homalg_project@207dc2b (the IsPackageMarkedForLoading-part needs gap-system/gap#3931 to work correctly).

If anything is unclear, just ask, then maybe we can improve the instructions :-)

@HereAround
Copy link
Member

Can this one be closed?

@zickgraf
Copy link
Member Author

I don't know, are all points addressed here?

@HereAround
Copy link
Member

We added the ToricVarieties packages to the test suite of the homalg_project. None of the other packages are tested. If you want this, we can extend the tests. If do you not want this, I believe we can close this issue.

@zickgraf
Copy link
Member Author

If you want this, we can extend the tests. If do you not want this, I believe we can close this issue.

This issue has emerged from the following comments:

So as far as I am concerned you can close the issue any time you like :-)

@HereAround
Copy link
Member

HereAround commented Feb 23, 2021

OK. I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants