-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google_translate component ignores punctuation. #43093
Comments
google_translate documentation |
I should note that this oddly does not present an issue when I call the service "tts.google_say" via developer tools. It only becomes an issue when I call it from a template in an automation. Developer Tools: tts.google_say
Says "The current time is eight pm". Automation:
Says "The current time is eleven zero zero pm" I've tested without the template in the automation with the same output: |
I have a similar problem with temperatures if used in a template in an automation. The decimal points in a temp are (un)pronounced as a pause, ie a full stop then the decimal part of the temp is said. Same as above, if done in developer tools it comes out correctly. |
The logic of the Google Translate integration has changed for the next release (0.119 / 1.0.0, scheduled 13 Dec). Please keep an eye on that release an report back if the issue still arises. See #43863 |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
I now see this reference to the #43863 issue, which brought me back to one of my own findings. Could you please have a look at those too, because they seem to be interrelated? thanks! #47220 #40925 |
That has nothing to do with this issue, so please close this one. |
I cant close this one |
Got around to testing it on the latest release. Looks like this is fixed. I will go ahead and close this issue. Thanks for everyone's work on the massive changes in the 2020.12 release! |
The problem
Google translate tts usage through the tts.google_say service ignores punctuation. For example, a message of "It is 5:00pm" generates audio of "It is 5 zero zero pm". If using google translate, we know that Google can generate audio of "It is five pm" from this text. This appears to be because of the "split_message_to_parts" function usage in the code.
Specifically it escapes the punctuation. However, I am unable to determine the reason for this.
punc = "!()[]?.,;:"
Environment
Problem-relevant
configuration.yaml
Traceback/Error logs
Additional information
This was discussed briefly here, but never resolved. https://community.home-assistant.io/t/a-stops-tts-google-say-from-further-speech/147069/5
The text was updated successfully, but these errors were encountered: