-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty files included by !include_dir_named #108489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
force-pushed
the
include_dir_named
branch
from
January 20, 2024 12:17
a7ca52a
to
b03b728
Compare
joostlek
approved these changes
Jan 20, 2024
frenck
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @emontnemery 👍
../Frenck
frenck
pushed a commit
that referenced
this pull request
Jan 20, 2024
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Merged
This was referenced Jan 20, 2024
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jan 21, 2024
…to v2024.1.5 (#324) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.4` -> `2024.1.5` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.5`](https://github.com/home-assistant/core/releases/tag/2024.1.5) [Compare Source](home-assistant/core@2024.1.4...2024.1.5) - Bump async-upnp-client to 0.38.1 ([@​StevenLooman] - [#​108382]) ([upnp docs]) ([yeelight docs]) ([dlna_dmr docs]) ([samsungtv docs]) ([ssdp docs]) ([dlna_dms docs]) (dependency) - Fix empty files included by !include_dir_named ([@​emontnemery] - [#​108489]) - Pin pandas to 2.1.4 ([@​frenck] - [#​108509]) [#​106970]: home-assistant/core#106970 [#​107239]: home-assistant/core#107239 [#​107365]: home-assistant/core#107365 [#​107883]: home-assistant/core#107883 [#​108379]: home-assistant/core#108379 [#​108382]: home-assistant/core#108382 [#​108489]: home-assistant/core#108489 [#​108509]: home-assistant/core#108509 [@​StevenLooman]: https://github.com/StevenLooman [@​emontnemery]: https://github.com/emontnemery [@​frenck]: https://github.com/frenck [dlna_dmr docs]: https://www.home-assistant.io/integrations/dlna_dmr/ [dlna_dms docs]: https://www.home-assistant.io/integrations/dlna_dms/ [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [ssdp docs]: https://www.home-assistant.io/integrations/ssdp/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/ [upnp docs]: https://www.home-assistant.io/integrations/upnp/ [yeelight docs]: https://www.home-assistant.io/integrations/yeelight/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/324 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is the 2nd try to restore the behavior of
!include_dir_named
which was changed by #103912, the solution in #107853 did not work in all casesType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: