Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank modal when trying to add Spotify service #18628

Closed
3 tasks done
Magic-Mayo opened this issue Nov 11, 2023 · 4 comments · Fixed by home-assistant/core#109102
Closed
3 tasks done

Blank modal when trying to add Spotify service #18628

Magic-Mayo opened this issue Nov 11, 2023 · 4 comments · Fixed by home-assistant/core#109102

Comments

@Magic-Mayo
Copy link

Magic-Mayo commented Nov 11, 2023

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

I've recently run into an issue when trying to add a Spotify service that results in a modal being displayed with no information. I found the problem I have in the logs but it would be nice if it actually displayed on the frontend and a user doesn't have to go digging thru logs to find the problem. My specific problem was that I had yet to setup the developer app for the new account I was trying to add.

image

Describe the behavior you expected

I expect to see an error message instead of a blank modal.

Steps to reproduce the issue

  1. Add a new Spotify service from the frontend before setting up a developer app with the account you're adding
  2. After you sign in to Spotify and click the link account button you are redirected back with a blank modal

What version of Home Assistant Core has the issue?

2023.11.2

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Google Chrome 118.0.5993.88

Which operating system are you using to run this browser?

popOS 22.04

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@karwosts
Copy link
Contributor

Is this something you're still able to reproduce? If I try to add a spotify integration, the first thing I see is this form:

image

I don't see how to get past this without "setting up a developer account". So I don't quite understand how you got where you are.

@Magic-Mayo
Copy link
Author

Magic-Mayo commented Nov 20, 2023

Yes, this only happens when adding an additional spotify service. I have one setup already and I want to add another separate account. I haven't been able to get the modal you've shown here with the additional account even after setting up the developer account. Sorry, I wasn't specific in my issue with stating it was for an additional account...thought I had put that 😅

@karwosts
Copy link
Contributor

@joostlek - let me know if this is something up your alley. I tried to see if there was something wrong in the frontend, but I don't have any spotify accounts, so I never was able to reproduce it. Maybe you know why it might have a blank step flow, or have some clues what might have happened.

@joostlek
Copy link
Member

Yep! Recently I've been debugging with someone else's Spotify credentials and encountered the same issue. I can take a look if we can raise a proper error here.

For your original question, about the empty models. I think whenever you encounter them it's a bug. This can mean a translation key for an abort is probably missing. Not sure how we can catch that (or where).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants