Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For discussion/architecture: Network Storage Issues: Proposed fix for: home-assistant/core #106446 #4856

Closed
jmealo opened this issue Jan 30, 2024 · 0 comments · Fixed by #4872
Labels

Comments

@jmealo
Copy link

jmealo commented Jan 30, 2024

Describe the issue you are experiencing

Proposed fix for: #4866

Preventing the error condition

When writing a backup

  • Use findmnt or similar to make sure that the network mount is in a good state when creating/writing a backup.
  • If the mount is in a good state: proceed.
  • If the mount is in a bad state, and a fallback location is configured: write to the fallback location and raise a notice to the user that the last backup was written to the fallback location.
  • If the mount is in a bad state, and a fallback location is not configured: raise a notice to the user that the last backup failed to write.

Follow-up enhancement

  • Add UI and/or background job to copy/sync backups from the fallback location when the mount is restored.

Recovering from the error condition

  • In the event that the mount point is a regular directory and contains valid backups, it should become the fallback directory, and a notice should be raised to the user that this has occurred.

Follow-up enhancement

  • Raise notice that backups are present in the fallback location but the option to copy them automatically has not been set up.

UI Fixes

  • Show fallback mount configuration guidance when network storage is the default destination and the mount fails (instead of showing the blank page). Explain how to setup robust backups with a transient storage server.

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Steps to reproduce the issue

  1. Use network storage for backups
  2. Have a backup occur when the storage mount is unavailable
  3. The next time the mount reconnects, it will fail due to a non-empty directory
    ...

Anything in the Supervisor logs that might be useful for us?

N/A

System Health information

System Information

version core-2024.1.5
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.11.6
os_name Linux
os_version 6.1.71-haos
arch x86_64
timezone America/New_York
config_dir /config
Home Assistant Community Store
GitHub API ok
GitHub Content ok
GitHub Web ok
GitHub API Calls Remaining 5000
Installed Version 1.33.0
Stage running
Available Repositories 1384
Downloaded Repositories 10
Home Assistant Cloud
logged_in true
subscription_expiration December 31, 2017 at 7:00 PM
relayer_connected false
relayer_region null
remote_enabled true
remote_connected false
alexa_enabled true
google_enabled true
remote_server null
certificate_status null
instance_id a070e6992e114b5397069af990d6ae9c
can_reach_cert_server ok
can_reach_cloud_auth ok
can_reach_cloud ok
Home Assistant Supervisor
host_os Home Assistant OS 11.4
update_channel stable
supervisor_version supervisor-2023.12.1
agent_version 1.6.0
docker_version 24.0.7
disk_total 30.8 GB
disk_used 21.7 GB
healthy true
supported true
board ova
supervisor_api ok
version_api ok
installed_addons Cloudflared (5.1.1), File editor (5.7.0), Glances (0.21.0), Studio Code Server (5.15.0), Frigate (Full Access) (0.12.1), Double Take (1.13.1), ESPHome (2023.12.9), openWakeWord (1.8.2)
Dashboards
dashboards 2
resources 0
views 2
mode storage
Recorder
oldest_recorder_run January 21, 2024 at 6:31 PM
current_recorder_run January 25, 2024 at 5:14 PM
estimated_db_size 991.45 MiB
database_engine sqlite
database_version 3.41.2

Supervisor diagnostics

No response

Additional information

No response

@jmealo jmealo added the bug label Jan 30, 2024
@jmealo jmealo changed the title Network Storage Issues: Proposed fix for #4357 Network Storage Issues: Proposed fix for: home-assistant/core/issues/106446 Jan 30, 2024
@jmealo jmealo changed the title Network Storage Issues: Proposed fix for: home-assistant/core/issues/106446 Network Storage Issues: Proposed fix for: home-assistant/core #106446 Jan 30, 2024
@jmealo jmealo changed the title Network Storage Issues: Proposed fix for: home-assistant/core #106446 For discussion/architecture: Network Storage Issues: Proposed fix for: home-assistant/core #106446 Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant