Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Dorita980 Roomba instances #66

Closed
karlvr opened this issue Sep 21, 2021 · 2 comments
Closed

Reuse Dorita980 Roomba instances #66

karlvr opened this issue Sep 21, 2021 · 2 comments
Assignees

Comments

@karlvr
Copy link
Collaborator

karlvr commented Sep 21, 2021

If we keep a Dorita980 instance open, the app is apparently not able to communicate with Roomba. It suggests Roomba supports one connection at a time. Therefore we should reuse an existing connection, if possible, when trying to concurrently talk to Roomba.

Implement reference counting.

@karlvr karlvr self-assigned this Sep 21, 2021
@rcoletti116
Copy link
Contributor

Perhaps semantics, but worth clarifying, the robot can only support one local connection at a time. If Dorita980 is connected the app does falls back to cloud connection.

@karlvr
Copy link
Collaborator Author

karlvr commented Sep 21, 2021

@rcoletti116 thank you. Right, and we don't have such a fallback mechanism, so I think reusing will be important if we have a situation where we are querying status and starting a clean at the same time.

@karlvr karlvr closed this as completed in ae578c0 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants