Verification Request: homebridge-intercom

[denisgabriel5]

Plugin Name

homebridge-intercom

Link To GitHub Repo

https://github.com/denisgabriel5/homebridge-intercom/

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No response

[github-actions]

🔴 The following pre-checks failed:

• Package JSON: homepage missing or does not start with https://
• Package JSON: more keywords apart from 'homebridge-plugin' should exist
• Package JSON: engines.homebridge property is not compatible with Homebridge 1.7.0
• GitHub Repo: should contain releases
• Config Schema JSON: does not contain a name schema property

---

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

[denisgabriel5]

/check

[github-actions]

🔴 The following pre-checks failed:

• GitHub Repo: should contain releases

---

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

[denisgabriel5]

/check

[github-actions]

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

🎉 All pre-checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

[bwp91]

Hi @denisgabriel5

I noticed we already have an existing verified plugin https://github.com/rooi/homebridge-intercom-automation-hat, I'm asking this purely since both this one and yours have intercom in the name, are they similar functionality or am I wrong here?

[denisgabriel5]

Hi @denisgabriel5

I noticed we already have an existing verified plugin https://github.com/rooi/homebridge-intercom-automation-hat, I'm asking this purely since both this one and yours have intercom in the name, are they similar functionality or am I wrong here?

Hi @bwp91

The plugin you mentioned is based only on Raspberry Pi. While my plugin currently supports only Shelly Uni based intercoms, I've put in the effort to allow it to add intercoms based on other devices as well.

[bwp91]

/check

[github-actions]

🟢 The following checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

[bwp91]

Hi @denisgabriel5

with a minimal config of:

        {
            "name": "Intercom",
            "manufacturer": "Default-Manufacturer",
            "model": "Default-Model",
            "serialNumber": "Default-Serial",
            "timeout": 10,
            "intercomType": "shellyUni",
            "shellyUniStatusUrl": "ksajdklasjdks",
            "shellyUniStatusJsonPath": "saljdklas",
            "shellyUniButtonsOrder": "open-talk",
            "shellyUniButtonsTimeout": 1,
            "shellyUniRingSuppressionTimeout": 0,
            "_bridge": {
                "username": "0E:C9:32:1E:39:47",
                "port": 38071
            },
            "platform": "Intercom Plugin"
        }

I receive the following crash loop:

[22/09/2024, 15:00:26] [Intercom] Executed didFinishLaunching callback
[22/09/2024, 15:00:26] [Intercom] Restoring existing intercom from cache: Intercom
[22/09/2024, 15:00:26] [Intercom] Started checking the intercom
[22/09/2024, 15:00:26] [Intercom] Triggered SET LockTargetState:  1
[22/09/2024, 15:00:27] Homebridge v2.0.0-beta.21 (HAP v1.1.1-beta.6) (Intercom) is running on port 38071.
TypeError: Invalid URL
    at new URL (node:internal/url:816:29)
    at dispatchHttpRequest (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/adapters/http.js:232:20)
    at /usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/adapters/http.js:152:5
    at new Promise (<anonymous>)
    at wrapAsync (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/adapters/http.js:132:10)
    at http (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/adapters/http.js:170:10)
    at Axios.dispatchRequest (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/core/dispatchRequest.js:51:10)
    at Axios._request (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/core/Axios.js:173:33)
    at Axios.request (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/core/Axios.js:40:25)
    at Axios.<computed> [as get] (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/core/Axios.js:199:17)
    at Axios.request (/usr/local/lib/node_modules/homebridge-intercom/node_modules/axios/lib/core/Axios.js:45:41)
    at Timeout._onTimeout (/usr/local/lib/node_modules/homebridge-intercom/src/shellyUni/shellyUniDoorbell.ts:42:27)
[22/09/2024, 15:00:28] [Intercom] Child bridge ended (code 1, signal null). The child bridge ended unexpectedly, which is normally due to the plugin not catching its errors properly. Please report this to the plugin developer by clicking on the 'Report An Issue' option in the plugin menu dropdown from the Homebridge UI. If there are related logs shown above, please include them in your report.
[22/09/2024, 15:00:28] [Intercom] Child bridge will automatically restart in 30 seconds (restart attempt 3 of 4).

Please update the plugin to ensure that the configuration is valid - in this case I assume the error is showing because this is not a valid URL in my config - shellyUniStatusUrl - but this could be checked and caught and an error log used instead of crashing the plugin.