Verification Request: homebridge-blaq

[KyleBoyer]

Plugin Name

homebridge-blaq

Link To GitHub Repo

https://github.com/KyleBoyer/homebridge-blaq

Plugin Icon (Optional)

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No response

[github-actions]

🔴 The following pre-checks failed:

• Package JSON: more keywords apart from 'homebridge-plugin' should exist
• Config Schema JSON: does not contain a name schema property

---

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

[KyleBoyer]

/check

[github-actions]

🔴 The following pre-checks failed:

• Package JSON: more keywords apart from 'homebridge-plugin' should exist
• Config Schema JSON: does not contain a name schema property

---

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

[KyleBoyer]

/check

[github-actions]

🟢 The following pre-checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

🎉 All pre-checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

[bwp91]

Hi @KyleBoyer

with a minimal config of:

        {
            "name": "Homebridge BlaQ",
            "platform": "BlaQHomebridgePlugin",
            "_bridge": {
                "username": "0E:D6:37:2B:F2:59",
                "port": 55165
            }
        }

I get the following crash loop:

[22/09/2024, 15:12:58] [Homebridge BlaQ] Executed didFinishLaunching callback
TypeError: this.config.devices is not iterable
    at BlaQHomebridgePluginPlatform.discoverDevices (file:///usr/local/lib/node_modules/homebridge-blaq/src/platform.ts:137:44)
    at HomebridgeAPI.<anonymous> (file:///usr/local/lib/node_modules/homebridge-blaq/src/platform.ts:53:12)
    at HomebridgeAPI.emit (node:events:519:28)
    at HomebridgeAPI.signalFinished (file:///usr/local/lib/node_modules/homebridge/src/api.ts:244:10)
    at ChildBridgeFork.startBridge (file:///usr/local/lib/node_modules/homebridge/src/childBridgeFork.ts:193:14)
[22/09/2024, 15:12:58] [Homebridge BlaQ] Child bridge ended (code 1, signal null). The child bridge ended unexpectedly, which is normally due to the plugin not catching its errors properly. Please report this to the plugin developer by clicking on the 'Report An Issue' option in the plugin menu dropdown from the Homebridge UI. If there are related logs shown above, please include them in your report.
[22/09/2024, 15:12:58] [Homebridge BlaQ] Child bridge will automatically restart in 30 seconds (restart attempt 3 of 4).
[22/09/2024, 15:13:29] [Homebridge BlaQ] Child bridge starting (pid 2949)...
[22/09/2024, 15:13:29] The plugin "homebridge-blaq" requires a Homebridge version of ^1.6.0 which does not satisfy the current Homebridge version of v2.0.0-beta.21. You may need to update this plugin (or Homebridge) to a newer version. You may face unexpected issues or stability problems running this plugin.
[22/09/2024, 15:13:29] The plugin "homebridge-blaq" requires a Node.js version of ^18.17.0 || ^20.9.0 which does not satisfy the current Node.js version of v22.9.0. You may need to upgrade your installation of Node.js - see https://homebridge.io/w/JTKEF
[22/09/2024, 15:13:30] Registering platform 'homebridge-blaq.BlaQHomebridgePlugin'
[22/09/2024, 15:13:30] [Homebridge BlaQ] Child bridge started successfully (plugin v0.2.32).
[22/09/2024, 15:13:30] [Homebridge BlaQ] Finished initializing platform: Homebridge BlaQ
[22/09/2024, 15:13:30] Publishing bridge accessory (name: Homebridge BlaQ, publishInfo: 

Please update the plugin to check that config.devices is present and an array before trying to loop over it!

[hjdhjd]

I’d also add - this plugin duplicates functionality that’s already in homebridge-ratgdo, another verified plugin which goes against this tenet of getting verified:

The plugin must not offer the same nor less functionality than that of any existing verified plugin.

[KyleBoyer]

@bwp91 The requested changes have been implemented

[KyleBoyer]

@hjdhjd Although homebridge-ratgdo does offer similar functionality for controlling a commercial version of ratgdo, there are Konnected GDO BlaQ specific features that homebridge-ratgdo do not implement for the specific Konnected GDO BlaQ - for example, the audible pre-close warning.

[hjdhjd]

I believe that’s the only documented feature that isn’t in homebridge-ratgdo, and happy to accept a PR to support it. 😄

[KyleBoyer]

/check

[github-actions]

🟢 The following checks passed:

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 18
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
• Package JSON: initializer function found
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases
• NPM Package: has not been deprecated
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency

---

🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.